On Fri, Feb 19, 2021 at 06:14:57PM -0500, Julian Braha wrote: > commit 1a3f343027d7f5a6475a019aa20be89795b8c8e0 > Author: Julian Braha <julianbr...@gmail.com> > Date: Fri Feb 19 17:02:24 2021 -0500 > > staging: rtl8192e: fix kconfig dependency on CRYPTO > > When RTLLIB_CRYPTO_TKIP is enabled and CRYPTO is disabled, > Kbuild gives the following warning: > > WARNING: unmet direct dependencies detected for CRYPTO_MICHAEL_MIC > Depends on [n]: CRYPTO [=n] > Selected by [m]: > - RTLLIB_CRYPTO_TKIP [=m] && STAGING [=y] && RTLLIB [=m] > > WARNING: unmet direct dependencies detected for CRYPTO_LIB_ARC4 > Depends on [n]: CRYPTO [=n] > Selected by [m]: > - RTLLIB_CRYPTO_TKIP [=m] && STAGING [=y] && RTLLIB [=m] > - RTLLIB_CRYPTO_WEP [=m] && STAGING [=y] && RTLLIB [=m] > > This is because RTLLIB_CRYPTO_TKIP selects CRYPTO_MICHAEL_MIC and > CRYPTO_LIB_ARC4, > without depending on or selecting CRYPTO, despite those config options > being subordinate to CRYPTO. > > Signed-off-by: Julian Braha <julianbr...@gmail.com> > > diff --git a/drivers/staging/rtl8192e/Kconfig > b/drivers/staging/rtl8192e/Kconfig > index 03fcc23516fd..6e7d84ac06f5 100644 > --- a/drivers/staging/rtl8192e/Kconfig > +++ b/drivers/staging/rtl8192e/Kconfig > @@ -26,6 +26,7 @@ config RTLLIB_CRYPTO_CCMP > config RTLLIB_CRYPTO_TKIP > tristate "Support for rtllib TKIP crypto" > depends on RTLLIB > + select CRYPTO > select CRYPTO_LIB_ARC4 > select CRYPTO_MICHAEL_MIC > default y
Odd indentation :(
