On 2021-03-22 17:28, Arnd Bergmann wrote: > On Mon, Mar 22, 2021 at 3:33 PM Richard Guy Briggs <r...@redhat.com> wrote: > > > Change the macros to use the usual "do { } while (0)" instead, and change > > > a > > > few more that were (void)0, for consistency. > > > > So what about audit_put_watch() and audit_get_watch() which are set to > > {}? (And all of include/linux/audit.h that uses the latter...) Does > > this only matter if they are the only action called in an if or loop? > > I missed those, thanks for pointing it out. I sent a v2 patch now.
Ok, cool, that looks more consistent. Can you answer my question about include/linux/audit.h and exactly what conditions require "do { } while (0)" over "{ }"? > Arnd - RGB -- Richard Guy Briggs <r...@redhat.com> Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada IRC: rgb, SunRaycer Voice: +1.647.777.2635, Internal: (81) 32635