On 19/03/2024 01:37, Tanmay Shah wrote: > Hello, > > Thanks for reviews, please find my comments below. > > On 3/17/24 9:50 AM, Conor Dooley wrote: >> On Fri, Mar 15, 2024 at 02:15:31PM -0700, Tanmay Shah wrote: >>> AMD-Xilinx Versal platform is successor of ZynqMP platform. Real-time >>> Processor Unit R5 cluster IP on Versal is same as of ZynqMP Platform. >> >>> Only difference is power-domains ID needed by power management firmware. >>> Hence, keeping the compatible property same as of zynqmp node. >> >> No, don't be lazy. Add a compatible with a fallback please. > > It's same IP on different platform. I am not sure how adding compatible string > adds value. I will refactor this series based on other comments provided.
Judging by your other thread, it would add value. Also writing bindings asks you for this. Best regards, Krzysztof
