On Thu, Nov 15, 2012 at 7:50 PM, Andy Shevchenko <andriy.shevche...@linux.intel.com> wrote: > diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
> +static inline bool dwc_is_slave(struct dma_slave_config *sconfig) > +{ > + return is_slave_direction(sconfig->direction); > +} I will not buy this one. Why hide the real implementation, call is_slave_direction() directly. > @@ -1344,6 +1352,8 @@ struct dw_cyclic_desc *dw_dma_cyclic_prep(struct > dma_chan *chan, > + sconfig->direction = direction; > + > @@ -1718,6 +1728,7 @@ static int __devinit dw_probe(struct platform_device > *pdev) > + dwc->dma_sconfig.direction = DMA_TRANS_NONE; Why do you need above changes?? -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/