On Fri, Dec 14, 2012 at 01:20:09PM +0900, Joonyoung Shim wrote: > The s3c->pwm_id is used to calculate offset of related register. > > Signed-off-by: Joonyoung Shim <jy0922.s...@samsung.com> > --- > drivers/pwm/pwm-samsung.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/pwm/pwm-samsung.c b/drivers/pwm/pwm-samsung.c > index 023a3be..b415102 100644 > --- a/drivers/pwm/pwm-samsung.c > +++ b/drivers/pwm/pwm-samsung.c > @@ -220,6 +220,8 @@ static int s3c_pwm_probe(struct platform_device *pdev) > return -ENOMEM; > } > > + s3c->pwm_id = id; > + > /* calculate base of control bits in TCON */ > s3c->tcon_base = id == 0 ? 0 : (id * 4) + 4;
Can you please move the assignment to below the above line? That way s3c initialization is more localized. Thierry
pgppXbhun0qiD.pgp
Description: PGP signature
