On Tuesday 09 April 2013, Harvey Harrison wrote: > > On Tue, Apr 9, 2013 at 11:39 AM, Lee Jones <lee.jo...@linaro.org> wrote: > > > > The aim is to make the code that little more readable. > > > > Signed-off-by: Lee Jones <lee.jo...@linaro.org> > > --- > > > > > #define MAX(a, b) (((a) < (b)) ? (b) : (a)) > > Not part of your patch, but probably a good idea to switch to the > generic MAX macro, this > one is evaluating its args twice.
Yes, good point. The macro is only used in one place, to compare two compile-time constant values, but we should define macros in drivers that are already provided by the kernel. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/