The current implementation of the DMA40's local MAX() macro evaluates its arguments more times than is necessary. This patch strips it optimises it to only evaluate what's appropriate.
Cc: Vinod Koul <vinod.k...@intel.com> Cc: Dan Williams <d...@fb.com> Cc: Per Forlin <per.for...@stericsson.com> Cc: Rabin Vincent <ra...@rab.in> Reported-by: Harvey Harrison <harvey.harri...@gmail.com> Signed-off-by: Lee Jones <lee.jo...@linaro.org> --- drivers/dma/ste_dma40.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c index b21a8a3..7b451b2 100644 --- a/drivers/dma/ste_dma40.c +++ b/drivers/dma/ste_dma40.c @@ -53,7 +53,7 @@ #define D40_ALLOC_PHY BIT(30) #define D40_ALLOC_LOG_FREE BIT(0) -#define MAX(a, b) (((a) < (b)) ? (b) : (a)) +#define MAX(a, b) ((a > b) ? a : b) #define D40_IS_SRC(dir) ((dir == STEDMA40_PERIPH_TO_MEM) ? true : false) #define D40_IS_DST(dir) (((dir == STEDMA40_MEM_TO_PERIPH) || \ -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
