Hello.
On 22-05-2013 16:59, Jiri Slaby wrote:
From: Jeff Mahoney <je...@suse.com>
This patch adds a module parameter to allow a group access to the
mISDN devices. Otherwise, unpriviledged users on systems with ISDN
hardware have the ability to dial out, potentially causing expensive
bills.
Based on a different implementation by Patrick Koppen <isdn4li...@koppen.de>
Acked-by: Jeff Mahoney <je...@suse.com>
Cc: Patrick Koppen <isdn4li...@koppen.de>
Signed-off-by: Jiri Slaby <jsl...@suse.cz>
Cc: Karsten Keil <i...@linux-pingi.de>
Cc: net...@vger.kernel.org
Cc: "David S. Miller" <da...@davemloft.net>
---
drivers/isdn/mISDN/core.c | 3 +++
drivers/isdn/mISDN/core.h | 1 +
drivers/isdn/mISDN/socket.c | 8 ++++++++
3 files changed, 12 insertions(+)
[...]
diff --git a/drivers/isdn/mISDN/socket.c b/drivers/isdn/mISDN/socket.c
index e47dcb9..71f4986 100644
--- a/drivers/isdn/mISDN/socket.c
+++ b/drivers/isdn/mISDN/socket.c
@@ -612,6 +612,10 @@ data_sock_create(struct net *net, struct socket *sock, int
protocol)
{
struct sock *sk;
+ if(!capable(CAP_SYS_ADMIN) && (misdn_permitted_gid != current_gid())
Did you run this thru scripts/checkpatch.pl? There should be space
after *if*. Also, () around != are not neccessary...
@@ -694,6 +698,10 @@ base_sock_ioctl(struct socket *sock, unsigned int cmd,
unsigned long arg)
case IMSETDEVNAME:
{
struct mISDN_devrename dn;
+ if(!capable(CAP_SYS_ADMIN)
Again, need space after *if*.
+ && (misdn_permitted_gid != current_gid())
Better leave && on a previous line and align the line under !. ()
again are not necessary.
+ && (!in_group_p(misdn_permitted_gid)))
() around !x are simply not needed -- ! operator has very high priority.
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
