Hello.

On 05/30/2013 01:09 AM, Davidlohr Bueso wrote:

Use the already defined macro to pass the function return address.

Signed-off-by: Davidlohr Bueso <davidlohr.bu...@hp.com>
---
  net/core/skbuff.c | 14 +++++++-------
  1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index af9185d..0d06850 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -116,22 +116,22 @@ static const struct pipe_buf_operations sock_pipe_buf_ops 
= {
   *    Keep out of line to prevent kernel bloat.
   *    __builtin_return_address is not used because it is not always reliable.
   */
-static void skb_panic(struct sk_buff *skb, unsigned int sz, void *addr,
+static void skb_panic(struct sk_buff *skb, unsigned int sz, unsigned long addr,
                      const char msg[])
  {
-       pr_emerg("%s: text:%p len:%d put:%d head:%p data:%p tail:%#lx end:%#lx 
dev:%s\n",
+       pr_emerg("%s: text:0x%lx len:%d put:%d head:%p data:%p tail:%#lx end:%#lx 
dev:%s\n",

Why not "text:%#lx" as already used in this string? It's equivalent to "0x%lx".

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to