On 19/07/13 12:01, Sean Young wrote: >> + int rval = 0; >> >> - return rdev->open(rdev); >> + if (!rdev->users++) >> + rval = rdev->open(rdev); >> + >> + if (rval) >> + rdev->users--; >> + >> + return rval; > > This looks racey. Some locking is needed, I think rc_dev->lock should work > fine for this. Here and in the lirc code path too. thanks Sean, It makes sense, will fix this in v2.
Srini > > Sean > >> } > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
