Hi Ming, On Thu, Jun 06, 2013 at 08:01:48PM +0800, Ming Lei wrote: > module reference doesn't cover direct loading path, so this patch > simply holds the module in the whole life time of request_firmware() > to fix the problem.
This does not make sense to me. If request_firmware() is executing that means some other module references it and module refcount already reflects that. We needed to pin module before Tejun's work ensuring that currently open sysfs entries won't keep related kobjects pinned after kernel marked them inactive. We can probably delete __module_get()/module_put() from firmware_class.c now. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
