On Tue, May 27, 2014 at 08:47:36AM +0200, Jonas Bonn wrote: > On 05/26/2014 10:52 PM, Geert Uytterhoeven wrote: > > CC devicetree for the bindings > > > > On Mon, May 26, 2014 at 10:31 PM, Stefan Kristiansson > > <stefan.kristians...@saunalahti.fi> wrote: > >> +++ > >> b/Documentation/devicetree/bindings/interrupt-controller/opencores,or1k-pic.txt > >> @@ -0,0 +1,23 @@ > >> +OpenRISC 1000 Programmable Interrupt Controller > >> + > >> +Required properties: > >> + > >> +- compatible : should be "opencores,or1k-pic-level" for variants with > >> + level triggered interrupt lines, "opencores,or1k-pic-edge" for variants > >> with > >> + edge triggered interrupt lines or "opencores,or1200-pic" for machines > >> + with the non-spec compliant or1200 type implementation. > >> + > >> + "opencores,or1k-pic" is also provided as an alias to > >> "opencores,or1200-pic", > >> + but this is only for backwards compatibility. > > I still think this identifier needs to be versioned. Use the same > version number as we have on the cpu identifier since the OR1200 PIC > hasn't changed since then; i.e. opencores,or1200-pic-rtlsvnXYZ. >
I can change that if you *really* insist on it... But I don't understand the purpose of the versioning here, there will never be any other or1200-pic version than the one that currently exists, so IMO "or1200" should be enough versioning information. Stefan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
