kmalloc_array manages count*sizeof overflow.

Cc: Phillip Lougher <phil...@squashfs.org.uk>
Cc: Andrew Morton <a...@linux-foundation.org>
Cc: Joe Perches <j...@perches.com>
Signed-off-by: Fabian Frederick <f...@skynet.be>
---
V2:
   use kmalloc_array instead of kcalloc (suggested by Joe Perches).

 fs/squashfs/file_direct.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/squashfs/file_direct.c b/fs/squashfs/file_direct.c
index 62a0de6..43e7a7e 100644
--- a/fs/squashfs/file_direct.c
+++ b/fs/squashfs/file_direct.c
@@ -44,7 +44,7 @@ int squashfs_readpage_block(struct page *target_page, u64 
block, int bsize)
 
        pages = end_index - start_index + 1;
 
-       page = kmalloc(sizeof(void *) * pages, GFP_KERNEL);
+       page = kmalloc_array(pages, sizeof(void *), GFP_KERNEL);
        if (page == NULL)
                return res;
 
-- 
1.8.4.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to