On Tue, Jun 17, 2014 at 01:48:59PM +0200, Arnd Bergmann wrote: > On Tuesday 17 June 2014, Vinod Koul wrote: > > > Anyway, if you use the __packed attribute, best apply it only to > > > the individual __u64 member(s), not the entire struct, otherwise > > > you might change user space programs in a subtle way when the alignment > > > changes from 4 to 1 byte. > > > > then wouldn't it make sense to call out the aligned as well to ensure that > > it is > > aligning to what we want. Then we should add aligned (4) everywhere as > > mostly we > > need 4 byte aligned here > > If you want to be explicit, then just mark the entire structure as > attribute((packed,aligned(4))), not each individual member. Oh yes, thats the idea. I will send out and also while reviewing found that packed was missing for few of other structs, so lets fix it now before 64bits systems proliferate and cause havoc :)
-- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
