On Tue, Oct 07, 2014 at 10:22:58AM +0100, Lee Jones wrote: > On Fri, 26 Sep 2014, Johan Hovold wrote: > > > Hot-pluggable multi-function devices should use PLATFORM_DEVID_AUTO to > > avoid name collisions on the platform bus. > > > > This driver currently uses the USB-device address as an id. This makes > > name collisions unlikely, but it could still happen if two devices are > > connected to separate buses and gets assigned the same address. > > > > Signed-off-by: Johan Hovold <jo...@kernel.org> > > --- > > drivers/mfd/rtsx_usb.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > This patch is superfluous.
Well, it would have documented the fact that there could be probe failures due to id collisions with current and older kernels. > Just wait until the hotpluggable version is applied, then use it. Fine with me. The collisions are quite unlikely anyway. Thanks, Johan > > diff --git a/drivers/mfd/rtsx_usb.c b/drivers/mfd/rtsx_usb.c > > index 71f387ce8cbd..78073e4b87e4 100644 > > --- a/drivers/mfd/rtsx_usb.c > > +++ b/drivers/mfd/rtsx_usb.c > > @@ -647,7 +647,7 @@ static int rtsx_usb_probe(struct usb_interface *intf, > > /* initialize USB SG transfer timer */ > > setup_timer(&ucr->sg_timer, rtsx_usb_sg_timed_out, (unsigned long) ucr); > > > > - ret = mfd_add_devices(&intf->dev, usb_dev->devnum, rtsx_usb_cells, > > + ret = mfd_add_devices(&intf->dev, PLATFORM_DEVID_AUTO, rtsx_usb_cells, > > ARRAY_SIZE(rtsx_usb_cells), NULL, 0, NULL); > > if (ret) > > goto out_init_fail; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
