On Sat, Feb 4, 2012 at 4:26 PM, Enrico <ebut...@users.berlios.de> wrote: > On Sat, Feb 4, 2012 at 12:48 PM, Gary Thomas <g...@mlbassoc.com> wrote: >> On 2012-01-30 10:30, Gary Thomas wrote: >>> >>> On 2012-01-20 05:19, Laurent Pinchart wrote: >>>> >>>> Hi Enrico, >>>> >>>> On Thursday 19 January 2012 15:17:57 Enrico wrote: >>>>> >>>>> On Thu, Jan 19, 2012 at 2:52 PM, Gary Thomas<g...@mlbassoc.com> wrote: >>>>>> >>>>>> On 2012-01-19 06:35, Gary Thomas wrote: >>>>>>> >>>>>>> My camera init code is attached. In the previous kernel, the I2C bus >>>>>>> was >>>>>>> probed implicitly when I initialized the OMAP3ISP. I thought I >>>>>>> remembered some discussion about how that worked (maybe changing), so >>>>>>> this is probably >>>>>>> where the problem starts. >>>>>>> >>>>>>> If you have an example, I can check my setup against it. >>>>>> >>>>>> >>>>>> Note: I reworked how the sensor+I2C was initialized to be >>>>>> omap3_init_camera(&cobra3530p73_isp_platform_data); >>>>>> >>>>>> >>>>>> omap_register_i2c_bus(cobra3530p73_isp_platform_data.subdevs->subdevs[0] >>>>>> .i2c_adapter_id, 400, >>>>>> >>>>>> cobra3530p73_isp_platform_data.subdevs->subdevs[0].board_info, 1); >>>>>> >>>>>> The TVP5150 is now found, but 'media-ctl -p' still dies :-( >>>>> >>>>> >>>>> Have a look at [1] (the linux_3.2.bb file to see the list of >>>>> patches,inside linux-3.2 directory for the actual patches), it's based >>>>> on mainline kernel 3.2 and the bt656 patches i submitted months ago, >>>>> it should be easy to adapt it for you board. >>>>> >>>>> <rant> >>>>> Really, there are patches for all these problems since months (from >>>>> me, Javier, TI), but because no maintainer cared (apart from Laurent) >>>>> they were never reviewed/applied and there is always someone who comes >>>>> back with all the usual problems (additional yuv format, bt656 mode, >>>>> tvp5150 that doesn't work...). >>>>> </rant> >>>> >>>> >>>> I totally understand your feeling. >>>> >>>> I'd like to get YUV support integrated in the OMAP3 ISP driver. However, >>>> I >>>> have no YUV image source hardware, so I can only review the patches but >>>> not >>>> test them. >>>> >>>> If someone can rebase the existing patches on top of >>>> http://git.linuxtv.org/pinchartl/media.git/shortlog/refs/heads/omap3isp- >>>> omap3isp-yuv and test them, then I'll review the result. >>>> >>> >>> The attached patches produce a working setup against Laurent's tree above. >>> That said, I don't recall exactly where which changes came from (I'm old >>> school and not very git savvy, sorry). I've CC'd all the folks I think >>> provided at least part of these changes. Perhaps we can all work together >>> to come up with a proper set of patches which can be pushed upstream >>> for this, once and for all? >>> >>> Thanks >>> >> >> Ping! Is no one but me interested in getting these changes into >> the mainline? > > I am interested, i didn't have time to test it but i will for sure. > > And i think it's important to test non bt656/yuv sensors too, but i > have no hardware for that. > > Enrico
I had some time to test your patches, i can confirm they work in my setup too but i have some doubts. 1- in the tvp5150 driver there is a hardcoded pal height (active area) of 576px, while it's true that it's the max pal area you will get i think it's wrong to force it in the driver because you will loose some image area (see [1] and [2]). It is better to return the max frame size and let the application crop it. And if i'm not wrong i think Javier posted a patch to add crop support in tvp5150 driver and that's even better. 2- as you can see from [1] and [2] image quality is very different, but i think it's just that in [1] top/bottom fields are swapped. For the above reasons and if there is a general consensus i propose to Laurent to just have a look at the patches i made some time ago (and i use everyday) from [3] and [4]. They are against mainline kernel but can be ported to whatever branch, once and for all. Enrico [1]: http://img822.imageshack.us/img822/1208/frame08.png [2]: http://img688.imageshack.us/img688/81/frame081.png [3]: https://github.com/ebutera/meta-igep/tree/master/recipes-kernel/linux/linux-3.2/omap3isp [4]: https://github.com/ebutera/meta-igep/tree/master/recipes-kernel/linux/linux-3.2/tvp5150 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
