On Mon, 2011-03-07 at 07:51 -0600, Cousson, Benoit wrote: > + Rajendra > > Hi Tomi, > > On 3/7/2011 9:22 AM, Valkeinen, Tomi wrote: > > Hi Kevin, Paul, > > > > We currently have a small problem with OMAP4 DSS. When we enable the DSS > > clocks, it seems that the DSS registers are not always accessible right > > after the clock enable. > > What clocks are you talking about? As you know, the DSS has a bunch of > functional clocks available depending of the use case.
In this case the clocks for DISPC, iclk and fclk. On OMAP4 fclk is DSS_FCLK and iclk is not used, I believe. The problem is probably also in all the other DSS modules. > > I understood that on OMAP4 the clock framework doesn't guarantee that > > the registers are accessible after enabling clocks, and pm_runtime will > > handle this. Is this correct? > > The point is that there is no status at clock level but only one status > at module level. That's why this check does not have anything to do at > clock level. > So hwmod with handle that status (OMAP4430_CM_DSS_DSS_CLKCTRL) during > the hwmod_enable that is indirectly called by pm_runtime, through > omap_device API. Ah. Ok. How does CM_DSS_DSS_CLKCTRL show that the DSS module is ready? IDLEST is 0? > > I have made a small hack fix for this. I added udelay(10) in the DSS > > code which enables the clocks and this seem to remove the problem. The > > delay is only called when DSS thinks the clocks have been off, so in > > practice the delay shouldn't be visible. Is this fix acceptable for now, > > until we get pm_runtime support to DSS? > > Cannot you use omap_device for the moment? Relying on a udelay is not a > very safe method, even temporally. Yes, udelay is not very good option even as a hack, except if we can wait some amount of time which we know will always be enough. Can we? I have to say I'm not very familiar with omap_device, as I haven't been really working with them (nor hwmods). Sumit or Archit can perhaps fill in, but my understanding is that work on that area is going on, but it's not ready yet. So I'm looking for some temporary quick solution for this so that DSS driver doesn't randomly crash on OMAP4. Tomi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
