On 12/17/13 17:48, Upinder Malhi wrote: > Sparse spit out few functions should be static warnings. This > patch provides a fix for the warnings. > > [ ... ] > @@ -579,6 +580,7 @@ static void __exit usnic_ib_destroy(void) > { > usnic_dbg("\n"); > usnic_debugfs_exit(); > + usnic_transport_fini(); > unregister_netdevice_notifier(&usnic_ib_netdevice_notifier); > pci_unregister_driver(&usnic_ib_pci_driver); > usnic_uiom_fini();
To me the above looks like a behavior change and not just a fix for a sparse warning. Shouldn't this change be moved into a separate patch ? Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html