Bart, This has been fixed in the latest patchset: http://www.spinics.net/lists/linux-rdma/msg18170.html http://www.spinics.net/lists/linux-rdma/msg18171.html
Upinder On Dec 21, 2013, at 1:58 AM, Bart Van Assche <bvanass...@acm.org> wrote: > On 12/17/13 17:48, Upinder Malhi wrote: >> Few printks in usnic are called w/o a string literal. >> Intel GCC is throwing warnings and this patch provides a fix >> for these. >> >> [ ... ] >> @@ -372,8 +372,7 @@ static void usnic_ib_undiscover_pf(struct kref *kref) >> } >> } >> >> - if (!found) >> - WARN("Failed to remove PF %s\n", pci_name(dev)); >> + WARN(found, "Failed to remove PF %s\n", pci_name(dev)); >> >> mutex_unlock(&usnic_ib_ibdev_list_lock); >> } > > The old code printed a warning if found == 0. The new code prints a > warning if found != 0. If this is on purpose I think this change should > be in a separate patch. > > Bart. > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html