Bart, On 4/22/17 02:22, Bart Van Assche wrote: > On Fri, 2017-04-21 at 18:16 +0900, damien.lem...@wdc.com wrote: >> No functional change is introduced by this patch. > > Hello Damien, > > The only tree for which I know that this kind of whitespace / coding style > patches are welcome is the staging tree. In general such patches are not > considered welcome because: > - Such patches pollute the changelog and make it harder to use tools like > git annotate / git blame. > - Such patches make it harder for distro maintainers to backport patches > from upstream kernels to distro (enterprise) kernels. > - If any kernel developer has developed kernel patches for the sd driver > against kernel v4.11 and wants to submit these after the v4.12 merge > window then that developer will have to rebase (and retest) these > patches on top of kernel v4.12-rc1. Whitespace patches trigger really > ugly rebase conflicts and hence are painful for other kernel developers. > > Hence my request to drop this patch.
OK. As I said, this patch was "optional". Just wondering though how we are supposed to do code maintenance if that kind of trivial cleanup cannot go in... (not to mention that checkpatch keep warning about white spaces in sd.c if a patch touches something near one of those multiple lines with white spaces). But fine, let's drop it. -- Damien Le Moal, Western Digital
