Like sd_pr_command, before use sshdr, we need to check the result
of scsi_execute.

submit_rtpg/submit_stpg
  scsi_execute

Signed-off-by: zhengbin <zhengbi...@huawei.com>
---
 drivers/scsi/device_handler/scsi_dh_alua.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c 
b/drivers/scsi/device_handler/scsi_dh_alua.c
index f32da0c..97c38ed 100644
--- a/drivers/scsi/device_handler/scsi_dh_alua.c
+++ b/drivers/scsi/device_handler/scsi_dh_alua.c
@@ -548,7 +548,8 @@ static int alua_rtpg(struct scsi_device *sdev, struct 
alua_port_group *pg)
                        kfree(buff);
                        return SCSI_DH_OK;
                }
-               if (!scsi_sense_valid(&sense_hdr)) {
+               if (driver_byte(retval) != DRIVER_SENSE ||
+                   !scsi_sense_valid(&sense_hdr)) {
                        sdev_printk(KERN_INFO, sdev,
                                    "%s: rtpg failed, result %d\n",
                                    ALUA_DH_NAME, retval);
@@ -773,7 +774,8 @@ static unsigned alua_stpg(struct scsi_device *sdev, struct 
alua_port_group *pg)
        retval = submit_stpg(sdev, pg->group_id, &sense_hdr);

        if (retval) {
-               if (!scsi_sense_valid(&sense_hdr)) {
+               if (driver_byte(retval) != DRIVER_SENSE ||
+                   !scsi_sense_valid(&sense_hdr)) {
                        sdev_printk(KERN_INFO, sdev,
                                    "%s: stpg failed, result %d",
                                    ALUA_DH_NAME, retval);
--
2.7.4

Reply via email to