On Wednesday 14 April 2004 22:39, Oliver Neukum wrote:
> > > I would prefer a real WARN_ON() so that the imbedded people compiling
> > > for size are not affected.
> >
> > What do you mean? How is a real WARN_ON() better?
>
> WARN_ON can be defined away to make a smaller kernel. Code that does
> not use it takes away that option.
Hi Oliver, I thought you meant that CONFIG_EMBEDDED made WARN_ON go away
(or something like that). If you just mean that it is easy to redefine WARN_ON by
hand, then all I can say is: it is also easy to redefine warn by hand! Anyway, I made
you the following patch:
--- gregkh-2.6/include/linux/usb.h.orig 2004-04-15 09:52:36.000000000 +0200
+++ gregkh-2.6/include/linux/usb.h 2004-04-15 09:56:30.000000000 +0200
@@ -1073,9 +1073,15 @@
#define dbg(format, arg...) do {} while (0)
#endif
-#define err(format, arg...) printk(KERN_ERR "%s: " format "\n" , __FILE__ , ## arg)
+#if !defined(CONFIG_EMBEDDED) || defined(DEBUG)
#define info(format, arg...) printk(KERN_INFO "%s: " format "\n" , __FILE__ , ## arg)
#define warn(format, arg...) printk(KERN_WARNING "%s: " format "\n" , __FILE__ , ##
arg)
+#else
+#define info(format, arg...) do {} while (0)
+#define warn(format, arg...) do {} while (0)
+#endif
+
+#define err(format, arg...) printk(KERN_ERR "%s: " format "\n" , __FILE__ , ## arg)
#endif /* __KERNEL__ */
-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
