Hi Alan, just one comment at the moment:
>>> + dev_err(printdev(devrec), >>> + "SPI write Failed for short register 0x%hhx\n", >>> reg); >>> + goto out; >> Hmmm, what does this goto mean? > > I could change the "out" labels if you prefer. Some other ieee802154 > drivers (serial.c) use "out", others (cc2420) use "err_ret", and other > use "err" or "fail" for this kind of single-error exit-the-function-now > kind of condition. > > I'll make them whichever you prefer :) I mean that it hasn't any sense due to the label "out" goes right after this goto. > Currently I have no time to review your updated patch, I'll do it during this week. With best regards, Alexander ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Linux-zigbee-devel mailing list Linux-zigbee-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel
