On 06/18/2012 02:24 AM, Alexander Smirnov wrote: >>>> + dev_err(printdev(devrec), >>>> + "SPI write Failed for short register 0x%hhx\n", >>>> reg); >>>> + goto out; > I mean that it hasn't any sense due to the label "out" goes right > after this goto. >
Ok, I see what you mean. I see about 4 places like that in the code. I'll fix it up. Thanks for the clarification. > Currently I have no time to review your updated patch, I'll do it > during this week. Sounds good, and thanks for letting me know. I'll get v4 posted soon with the goto fix. As far as the BUG_ON() issue goes, the bad values should never actually happen, because the driver gives the channel mask to the mac80211 layer and it would be a bug if the mac80211 layer then called .set_channel() with a channel that wasn't in the mask. Since maybe BUG_ON() is too severe here, how about WARN_ON() instead? Alan. ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Linux-zigbee-devel mailing list Linux-zigbee-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel
