>>>>> "Bo" == Bo Peng <[EMAIL PROTECTED]> writes:

Bo> Finally, a patch that fixes a critical bug (as opposed to fixing
Bo> WONTFIX). :-) Description:

Bo> Create a 2 by 1 table with several characters in the lower cell,
Bo> select both cells and S-Right when the cursor is in the upper
Bo> cell. This crashes lyx.

I do not think the analysis is correct. The real problem is that
saveSelection is not prepared (like most of our cut-and-paste
mechanism) to handle multi-cell selections.

The attached patch fixes the crash, but I am not confident at all that
it is really the correct solution.

JMarc

Index: src/CutAndPaste.cpp
===================================================================
--- src/CutAndPaste.cpp	(révision 18694)
+++ src/CutAndPaste.cpp	(copie de travail)
@@ -607,6 +607,10 @@ void copySelectionToStack(Cursor & cur, 
 	if (!cur.selection())
 		return;
 
+	// we cannot handle the situation of multiple cells yet
+	if (cur.selBegin().idx() != cur.selEnd().idx())
+		return;
+
 	if (cur.inTexted()) {
 		Text * text = cur.text();
 		BOOST_ASSERT(text);

Reply via email to