On 03/07/2017 06:16 AM, Jean-Marc Lasgouttes wrote: > Le 07/03/2017 à 12:08, Jean-Marc Lasgouttes a écrit : >> commit dc126bad0441eb8721043e597657d5c18bdf6c90 >> Author: Jean-Marc Lasgouttes <lasgout...@lyx.org> >> Date: Tue Mar 7 12:02:54 2017 +0100 >> >> Fix typo found by coverity >> >> We were not testing for the right end(), although it is not sure >> that >> an actual bug could be triggered because of that. > > Richard, > > This is a bug that you marked as false positive on coverity. Do you > agree now that the fix was needed?
Yes, that looks right. > Actually there are other uses of the variable `formats' in > Formats.cpp, and I think that they are all incorrect (should be > formatlist). This will not matter in most cases, fortunately. I will try to have a look at this. > A good way to avoid this would be to instantiate formats and > system_formats in some other .cpp file. They should not be available > in Format.cpp. What is the correct idiom for this? I'm afraid I would not know that.... Richard
