On 03/14/2017 09:28 AM, Jean-Marc Lasgouttes wrote:
> Le 14/03/2017 à 04:41, Richard Heck a écrit :
>> On 03/13/2017 12:05 PM, Jean-Marc Lasgouttes wrote:
>>> Le 13/03/2017 à 16:18, Richard Heck a écrit :
>>>> I'll move the formats variable to the singleton, too. That seems worth
>>>> doing, yes, and should be painless?
>>>
>>> I think it should be a bit long, but painless.
>>
>> Done. Not too long, but definitely painless.
>
> I fixed some problems found in the commit (2 warnings and a filaed test).

Thanks for catching the warnings, which were obviously genuine problems.
I'm not sure why I did not get them.

Nice illustration of why the global 'formats' variable was a bad idea.

Richard

Reply via email to