> Am 17.04.2017 um 17:23 schrieb Kornel Benko <kor...@lyx.org>: > > Am Montag, 17. April 2017 um 15:40:51, schrieb Stephan Witt <st.w...@gmx.net> >> Am 16.04.2017 um 22:45 schrieb Scott Kostyshak <skost...@lyx.org>: >>> >>> On Sat, Apr 15, 2017 at 08:44:59AM +0200, Stephan Witt wrote: >>> >>>>> Also, do you think we should consider reverting 9b64d7bd? I hope not, >>>>> but I ask you since I think at this point you have the best >>>>> understanding of the situation. >>>> >>>> No, I don’t think so. You had good reasons and shouldn’t be reverted. >>> >>> OK good. >>> >>>> For me it looks a little bit strange to access the contents of the lyxrc >>>> object directly. This would be another possibility: to make all (path) >>>> member variables private and use setter and getter for accesses. The tilde >>>> logic could be placed inside the getter then. >> >> ATM, I’m trying to avoid that. I fear it’s too much changed then. >> >> So, I’m reviewing the affected path variables in LyXrc now. >> >> 1. document_path - most usages are with FileName. >> But I’m not sure if the usage of it in browseRelToSub() is ok. >> On Mac it’s ignored because of USE_NATIVE_FILEDIALOG being true. >> >> 2. example_path - isn’t used anymore !!??? > > It is used in non-native file selector dialog, (ergo not on Mac)
I’m making a code review and not a debugger session ;) I’m not so sure it is really used now. I’m quite confident the path for the button you’re talking about is hard coded and not retrieved from lyxrc. Stephan > >> 3. template_path - like document_path >> >> 4. tempdir_path - is parameter of FileName only, ok. >> >> 5. thesaurusdir_path - is parameter of FileName only, ok. >> >> 6. hunspelldir_path - is parameter of FileName only, ok. >> >> 7. lyxpipes - is parameter of FileName only, ok. >> >> 8. backupdir_path - is parameter of FileName only, ok. >> >> Stephan > > Kornel
