On Sat, Dec 31, 2022 at 12:49 PM Udicoudco <udifog...@gmail.com> wrote:
> > > On Sat, Dec 31, 2022 at 10:33 AM Thibaut Cuvelier <dourou...@gmail.com> > wrote: > >> On Sat, 31 Dec 2022 at 03:36, Scott Kostyshak <skost...@lyx.org> wrote: >> >>> On Sat, Dec 31, 2022 at 02:00:34AM +0100, Thibaut Cuvelier wrote: >>> > I've pushed your patch online: 42c2a25fb8. I had to rebase it >>> manually, I >>> > hope I didn't make too many mistakes. I'm also attaching the patch to >>> this >>> > email so that you can check it more easily if you want. >>> > >>> > (If someone can add Udi to the blanket permissions, here is the link >>> on the >>> > mailing list: https://marc.info/?l=lyx-devel&m=165779733507955&w=2) >>> > >>> > Thibaut Cuvelier >>> >>> Some ctests are failing on current master. I'm not sure if it's because >>> of your recent commit or not. >>> >>> But, for example, if I open up lib/doc/Additional.lyx, I get a message >>> about a module that is not found: theorems-ams-extended >>> >>> Also some tex2lyx tests are failing. Can you check those as well? >>> >> >> Given the failures, I'm reverting the commit, especially as Udi is >> working on a new version. For the missing modules, I suppose that Udi >> should restore the corresponding .module files, even if they just include >> something else, or could we do something about it in lyx2lyx? (I.e. does >> this change warrant a format update?) >> -- >> > I will restore the missing modules, so we don't need to do anything about > lyx2lyx. > If i ill change the non-AMS modules to not use amsthm, and will add to their name `-plain` prefix, would it be possible to make lyx2lyx update files using e.g. theorems.module to use theorems-ams.module? If so, I could add the changes to the non-AMS modules to the patch, but I don't know anything about lyx2lyx. > >> lyx-devel mailing list >> lyx-devel@lists.lyx.org >> http://lists.lyx.org/mailman/listinfo/lyx-devel >> >
-- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel