Rafael Garcia-Suarez wrote:
>> 29357 should be reverted.
> 
> but if I do that, the test fail in bleadperl:
> 
> [EMAIL PROTECTED] t]$ ./perl -MTestInit ../lib/ExtUtils/t/build_man.t
> 1..9
> ok 1 - setup
> ok 2 - chdir'd to Big-Dummy
> ok 3
> not ok 4
> #   Failed test at ../lib/ExtUtils/t/build_man.t line 51.
> ok 5
> ok 6
> ok 7
> ok 8
> ok 9 - teardown
> # Looks like you failed 1 test of 9.

That's because the "local $Config{installman3dir}" got moved to the wrong block 
when it was patched on top of 29357.

0 windhund ~/devel/ExtUtils-MakeMaker$ diff -u t/build_man.t 
/usr/local/src/bleadperl/lib/ExtUtils/t/build_man.t 
--- t/build_man.t       2006-10-27 12:31:36.000000000 -0700
+++ /usr/local/src/bleadperl/lib/ExtUtils/t/build_man.t 2007-02-22 
10:33:49.000000000 -0800
@@ -42,9 +42,11 @@
 
 ok( my $stdout = tie *STDOUT, 'TieOut' );
 
-{
-    local $Config{installman3dir} = File::Spec->catdir(qw(t lib));
-
+SKIP: {
+    skip ("installman3dir is null", 1)
+       if !$Config{installman3dir} or
+           $Config{installman3dir} !~ /\S/ or
+           $Config{installman3dir} eq 'none';
     my $mm = WriteMakefile(
         NAME            => 'Big::Dummy',
         VERSION_FROM    => 'lib/Big/Dummy.pm',
@@ -54,6 +56,8 @@
 }
 
 {
+    local $Config{installman3dir} = File::Spec->catdir(qw(t lib));
+
     my $mm = WriteMakefile(
         NAME            => 'Big::Dummy',
         VERSION_FROM    => 'lib/Big/Dummy.pm',

Reply via email to