Gertjan, thanks for your efforts!
Gertjan van Oosten wrote: > Done this for widgets, tools, models, examples and util. > Also used getNodeValue() and Mapbuilder.parseBoolean() where > appropriate. > I think replacing firstChild.nodeValue with getNodeValue() was the most effort, and I am not sure if this was a good idea, because Jean-Sebastien was referring to parsing context properties when he said that firstChild.nodeValue does not work. > It turned out to be a non-trivial amount of work. Although I tried to > test as thoroughly as possible, it is not unlikely that there's an error > or two in my refactorings. Testing (and feedback thereof) by others is > welcome. > Trunk is broken. At least vector styles do not work any more. I suspect this is due to improper use of getNodeValue, but will do further investigations. > In lib/model/, there's four places left that use .firstChild.nodeValue, but > they use it as an LHS there and I don't know what it be turned into. > It is ok this way. > Furthermore, in lib/util/openlayers/OpenLayers.js, there's a *lot* of > places it is being used. I guess these should be fixed in OL. Since > your an OL committer, Andreas, I hope you can help there. > This is also ok, because it is only being used where we *know* that we want the nodeValue of the first child. There is no different behaviour of browsers in that case (except if a text node is larger than 4 KB in Gecko, but that's a different story). Regards, Andreas. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ mapbuilder-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mapbuilder-devel
