Gertjan van Oosten wrote: > As quoted from Andreas Hocevar: > >> I think replacing firstChild.nodeValue with getNodeValue() was the most >> effort, and I am not sure if this was a good idea, because >> Jean-Sebastien was referring to parsing context properties when he said >> that firstChild.nodeValue does not work. >> > > I do not understand what you mean by that. When does > node.firstChild.nodeValue not work exactly? And when does getNodeValue(node) > not return the equivalent of node.firstChild.nodeValue? My > impression/assumption was that the two had roughly identical meaning, and that > the method was only there to increase compatibility with Opera. >
Yes, that's what it was meant for. Jean-Sebastien never stated *when* exactly firstChild.nodeValue did not work. He just said he had troubles with it in Opera and Safari. But there is a difference of the getNodeValue method, because it returns the nodeValue directly if we don't use it on an element node. This is the reason why I thought the broken styles might have to do with introducing getNodeValue() in too many places. But it turned out that the problem was just that you renamed two properties in GmlRendererBase.js while doing the refactoring. This is now fixed. Can you please also check the baseLayer code in MapPaneOL again? I saw that there are some node.nodeValue statements in there, and I'm not sure if this is what you meant. > OK. > Fixed. I also did some more refactoring to use Mapbuilder.getProperty in some places. Thanks again for the good work on that! Regards, Andreas. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ mapbuilder-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mapbuilder-devel
