Nicolas Mailhot wrote: > Hi, > > In matplotlib 1.2.1, the get_name function is not garding against none > self (unlike other functions); Unfortunately it seems I have a workload > that makes matplotlib call get_name with None (wasn't the case in 1.2.0). > I couldn't isolate the exact trigger, when I reduce the volume of data > processed the problem goes away so I have to simple shareable reproducer. > > Anyway, the following patch makes it all work for me, could it (or > something similar) be merged? > > diff -uNr matplotlib-1.2.1.orig/lib/matplotlib/font_manager.py > matplotlib-1.2.1/lib/matplotlib/font_manager.py > --- matplotlib-1.2.1.orig/lib/matplotlib/font_manager.py 2013-03-26 > 14:04:37.000000000 +0100 > +++ matplotlib-1.2.1/lib/matplotlib/font_manager.py 2013-07-08 > 14:49:37.791845661 +0200 > @@ -721,6 +721,8 @@ > Return the name of the font that best matches the font > properties. > """ > + if self._family is None: > + return rcParams['font.family'] > return ft2font.FT2Font(str(findfont(self))).family_name > > def get_style(self): > > Regards, >
Could you instead just test for "if not self._family"? Tests for equality are more expensive (that means self._family == 0 or self._family == False will also trigger your return). ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev _______________________________________________ Matplotlib-users mailing list Matplotlib-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/matplotlib-users
