Hi Arjan, I checked with dev_err / dev_warn(). The implementation of dev_err / dev_warn() is printk(KERN_ERR args) and printk(KERN_WARNING args). The reason I didn't use dev_err / dev_warn() is there is no suitable (or easy to get) "dev" variable in ar6003 driver. So, I need to put NULL for this dev variable. Then dev_err will be printk(KERN_ERR "Null device" ...).
I think to show Null devie for ar6603 isn't good. -----Original Message----- From: Arjan van de Ven [mailto:ar...@linux.intel.com] Sent: Tuesday, June 14, 2011 11:01 PM To: Chang, Samuel Cc: Samuel Ortiz; Wu, Ricky; Huang, Maggie; meego-kernel@lists.meego.com; Yang, Jack Subject: Re: [Meego-kernel] [PATCH] ar6003 : reduce unnecessary log during driver loading V2 On 6/14/2011 7:58 AM, Chang, Samuel wrote: > Hi Samuel.Ortiz, > > Thanks your review. > > -#else >> #define A_LOGGER(mask, mod, args...) printk(KERN_ALERT args) >> I would rather use KERN_DEBUG or KERN_INFO here. > This is for Android and I would remove it from meego.kernel. > Because We won't use it. > > >> +#define A_PRINTF(args...) printk(KERN_ERR args) >> So all A_PRINTF will be errors ? Here as well, KERN_DEBUG or KERN_INFO would >> make more sense to me. > All A_PRINTF(), I will change it to AR_DEBUG_PRINTF(). > So, we can use debug level to control it. when you change it, please change it to dev_err / dev_warn() and co. that way you use the standard way of enabling/disabling the log level at runtime, and allows log analysis tools (for system health diagnostics in the field) to work with your driver. _______________________________________________ MeeGo-kernel mailing list MeeGo-kernel@lists.meego.com http://lists.meego.com/listinfo/meego-kernel
