On Sun, Mar 14, 2010 at 5:38 PM, tom fogal <tfo...@alumni.unh.edu> wrote: > It was a long while back that I wondered && somehow ended up > volunteering to detect platform TLS support, + enable it in Mesa / the > X server if available. > > I got distracted before finishing the X parts, but rebased the Mesa > parts, which are attached. > > One thing I'm worried about is using an AC macro archive macro here; > it's GPL + an exception that "configure" (the output) is unrestricted. > I'm not sure that'll be kosher for Mesa.
I don't think license of the build files affects the license of the code. We're already using lots of macros from autoconf that are almost certainly GPL. > OTOH, the macro is dead simple. > > Comments? I think I'd prefer if you added the macro directly to acinclude.m4 instead of adding more macro files. If we're going to do that, I'd rather have an explicit m4 directory. I don't think mesa quite needs that, though. Changing TLS to autodetect might be a good thing down the road, but I think we need to at least have the xserver following the settings before we make this change. Otherwise, nearly everybody is suddenly going to get TLS enabled in the DRI drivers who don't know they need to start passing another option to the xserver. So, I'd rather see these two patches broken up differently. 1. Export glx_tls from gl.pc 2. Autodetect TLS usage Then we can hold off applying 2 until we have the xserver part landed and we think it's safe to start defaulting (essentially) to using TLS. -- Dan ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
