Dan Nicholson <dbn.li...@gmail.com> writes: > On Sun, Mar 14, 2010 at 5:38 PM, tom fogal <tfo...@alumni.unh.edu> wrote: > > [I] volunteer[ed] to detect platform TLS support, + enable it in > > Mesa / the X server if available. > > > > One thing I'm worried about is using an AC macro archive macro here; > > it's GPL + an exception [. . .] > > I don't think license of the build files affects the license of the > code. We're already using lots of macros from autoconf that are almost > certainly GPL.
Okay, great. > > OTOH, the macro is dead simple. > > > > Comments? > > I think I'd prefer if you added the macro directly to acinclude.m4 > instead of adding more macro files. If we're going to do that, I'd > rather have an explicit m4 directory. I don't think mesa quite needs > that, though. Okay, I can integrate it directly. > Changing TLS to autodetect might be a good thing down the road, but > I think we need to at least have the xserver following the settings > before we make this change. Otherwise, nearly everybody is suddenly > going to get TLS enabled in the DRI drivers who don't know they need > to start passing another option to the xserver. Ahh, I see my memory was wrong; I figured a TLS driver could be used regardless. Digging up the old thread [1], it seems like it'd be possible, but currently not implemented as such. So, yes, I agree, autodetection shouldn't be applied until the X server keys into it. > So, I'd rather see these two patches broken up differently. > > 1. Export glx_tls from gl.pc > 2. Autodetect TLS usage Will do. -tom [1] http://lists.x.org/archives/xorg-devel/2009-November/003411.html ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
