On Tue, 06 Mar 2007, Adam Kennedy wrote: > I've now added checking of use constant { ... } to Perl::MinimumVersion > as 5.8.0.
> Let me know if this works ok for you. 1.14 reports v5.8.0 if use constant { ... } is in and v5.6.0 if it is out. So it works. > Adam Kennedy wrote: > >Eric Wilhelm wrote: > >>I've heard about Perl::MinimumVersion, though it doesn't seem to catch > >>this case in the little test I just tried. Looking at the source, it > >>certainly seems like it could handle it, though I suspect it would be > >>a good idea to source all of that juicy expert knowledge from data > >>files rather than embedding it in code. Not sure if Adam has anything > >>in mind for that. Anyway, some digging suggests this might catch it: > >> $doc->find_any(sub { > >> $_[1]->isa('PPI::Statement::Include') and > >> $_[1]->schild(2)->isa('PPI::Structure::Block') > >> }); > >>Though that could also be a list containing a block (which is actually > >>a hashref, but those don't seem to be distinguished.) > >Never ever heard of that use of use constant to be honest. > >So you've found at least one patch-worth (or commit bit worthy) > >addition, and by the sound of it on possible bug as well. > >Wanna fix that? > >Adam K -- Greg Matheson If there is one thing we learn from the study of language learning, it is that language learners learn more than we learn. -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.