Hi Roger,

How do you perform your perlcritic runs?

I can recommend the verbosity setting 8

        perlcritic --verbose 8

This gives you quite friendly policy identifiers

[ValuesAndExpressions::ProhibitConstantPragma] Pragma "constant" used at line 22, column 1. (Severity: 4)

well my favorite anyway

jonasbn

On 18/02/2009, at 21.17, Roger Hall wrote:

I had to dig around in the policy modules because it isn't actually listed
in the other document I linked.

Specifically: ProhibitAccessOfPrivateData

I'm only sure this is it because the error message that came out of the
report ...

"Private Member Data shouldn't be accessed directly at line X, column Y.
Accessing an objects data directly breaks encapsulation and should be
avoided."

... is prominently displayed in the module.

Thanks!

Roger

-----Original Message-----
From: Bill Ward [mailto:b...@wards.net]
Sent: Wednesday, February 18, 2009 11:11 AM
To: raha...@ualr.edu
Subject: Re: ARGH! (was FW: Perl Critic and (honest) hash references)

What was the solution?

On Wed, Feb 18, 2009 at 8:53 AM, Roger Hall <raha...@ualr.edu> wrote:
RTFM is always pretty good advice, eh? :}

-----Original Message-----
From: Roger Hall [mailto:raha...@ualr.edu]
Sent: Wednesday, February 18, 2009 10:05 AM
To: module-authors@perl.org
Subject: Perl Critic and (honest) hash references

$config->{query}

Perlcritic complains that "Private Member Data shouldn't be accessed
directly" because "Accessing an objects data directly breaks encapsulation and should be avoided". I get that. Only problem: it's not an object. It's
just a hashref.



Reply via email to