On 11/3/22 11:20, Joshua Watt wrote:
On 11/3/22 09:49, Konrad WEIHMANN wrote:
so what's the conclusion? I would be okay to add a var like
SPDX_SHARED_SOURCE (default WORKDIR) or something and reference this
as a default - when using a weak default ppl could override that to
their needs...
Ya, I think what you have is fine with a minor change; the limitations
of not handling non-kernel shared source very well isn't changing. I
did leave a minor comment in github, but otherwise LGTM
Per discussion on GitHub, this is fine to merge as is. Thanks
Would that be something that would work?
------------------------------------------------------------------------
*From:* Joshua Watt <jpewhac...@gmail.com>
*Sent:* Thursday, November 3, 2022 3:28 PM
*To:* Konrad WEIHMANN <kweihm...@witekio.com>;
openembedded-core@lists.openembedded.org
<openembedded-core@lists.openembedded.org>
*Cc:* st...@sakoman.com <st...@sakoman.com>
*Subject:* Re: [OE-core] [PATCH 0/1] create-spdx: default share_src
for shared sources
I see the problem, but I'm not quite sure this is the correct solution.
It *does* fix the problem for exact recipe that provides the source code
(e.g. the llvm-sources recipe), but I don't think it will correctly pick
up the sources for anything that actually uses that shared source code
(e.g. clang); this isn't necessarily a problem in your patch however, I
think it's actually a problem with any non-kernel recipes.
On 11/3/22 09:15, Konrad WEIHMANN via lists.openembedded.org wrote:
> https://github.com/witekio-kwe/poky spdx-fix
Witekio GmbH is registered in Frankfurt. Registered office: Am
Wartfeld 7 - 61169 Friedberg. Registered company number: HRB 95432.
VAT number DE287400071
This message contains confidential information and is intended only
for the individual(s) addressed in the message. If you aren't the
named addressee, you should not disseminate, distribute, or copy this
e-mail.
We continuously commit to comply with the applicable data protection
laws and ensure fair and transparent processing of your personal
data. Please read our privacy statement including an information
notice and data protection policy for detailed information on our
website.
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#172647):
https://lists.openembedded.org/g/openembedded-core/message/172647
Mute This Topic: https://lists.openembedded.org/mt/94757133/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
