On Thu, Dec 27, 2012 at 9:07 AM, Øyvind Harboe <[email protected]> wrote: > it does seem that you've run into one of those cases where Gerrit is > *not* a perfect match, near as I can see. > > A couple of suggestions: > - identify those of your patches that are uncontroversial and > independent of your more serious SWD work. Ask the list to review and > submit them. If there are many, then focus on, say 5, at the time so > as not to overload the list.
I know there are series of patches, but that series is as compact as possible, and this is the whole thing that makes SWD work using LibSWD. Commits are small and each one of them brings some new functionality. I would love to have them commited into master so I can work along with other stuff :-) Existing SWD code in OpenOCD is extrelmely experimental anyways so people that work on their own implementation will know what to do, other functionalities remains untouched :-) I want to move forward for internals reorganization, so adding new interfaces, transport and targets is easier and standarized... at the moment everyone creates their own implementation and this is not the best way I guess :-) > - create one or more new branches locally based on latest master. > Manually cherry-pick each of the reviews onto the local branch. Each > branch should contain work independent of other work. I will try thanks :-) I just was wondering on how to work with Gerrit when other people update your commits that are already on the Gerrit, there should be a easy way for this, we should document that in Developers Guide as well :-) Best regards :-) Tomek -- CeDeROM, SQ7MHZ, http://www.tomek.cedro.info ------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnmore_122712 _______________________________________________ OpenOCD-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openocd-devel
