Hello Carsten, thanks for your review and edits, on closer inspection i also noted some issues in my code. I removed the commented code bits and changed create() to createLocal() in two occasions (a question here: does it matter? what are the differences between UnrecPtrs/createLocal() and RecPtrs/create()?).
I also edited the GLSL code in the test app to be compatible to OpenGL 2.1/GLSL 1.20 instead of 3.30. The changed code is again available at www.cip.ifi.lmu.de/~langal/osg_depthpeel.zip. The test currently still requires OpenSG to be compiled with OSG_ENABLE_OGL_VERTEXATTRIB_FUNCS on. My question: could this switch be enabled by default? Concerning documentation I also think that the tutorial at http://www.opensg.org/wiki/Tutorial could use some update with a new chapter devoted to the various stages and their usage. Also the patch could remove the fprintf(stderr, "bp : %d\n", basepoint); in OSGSimpleGeometry.cpp. Kind regards, Alex > Hello again, > > On 09/18/2012 04:57 PM, Carsten Neumann wrote: >> thank you very much for the contribution! I haven't looked at the code >> yet, hoping to get a chance to do so within the week. > > ok, attached is the patch that I'm considering to commit. I think the > stage does fit nicely into the EffectGroups library, so I've added it in > the new Source/System/NodeCores/Groups/Effects/OIT directory [1]. > Biggest change is to the test program which I've converted to not use > Qt, but only GLUT, so that it can be used with fewer/simpler dependencies. > Unless there are any objections I'll commit this in a few days. > > Cheers, > Carsten > > [1] an alternative would be to put it into a separate contrib library, > but I don't really see a strong reason to do so. > ------------------------------------------------------------------------------ > Got visibility? > Most devs has no idea what their production app looks like. > Find out how fast your code is with AppDynamics Lite. > http://ad.doubleclick.net/clk;262219671;13503038;y? > http://info.appdynamics.com/FreeJavaPerformanceDownload.html_______________________________________________ > Opensg-users mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/opensg-users > ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Opensg-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensg-users
