----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/18/#review32 -----------------------------------------------------------
..testing the review system (hi mom!).. indra/newview/app_settings/settings.xml <http://codereview.secondlife.com/r/18/#comment15> Considering the setting name (CacheLocationTopFolder), isn't the deleted Comment string better than the one you left in? Thus, Controls the top folder location of the the local disk cache, rather than Controls the location of the local disk cache. Diff is ok with me, I just wondered if you saw that it wasn't an exact duplicate. indra/newview/app_settings/settings.xml <http://codereview.secondlife.com/r/18/#comment16> This deletes the entry with 60 seconds between printing the FPS and leaves the one that has 10 seconds between printing. Which is the correct one? indra/newview/app_settings/settings.xml <http://codereview.secondlife.com/r/18/#comment17> This really looks wrong. The first OutBandwidth has Comment that has nothing to do with OutBandwidth and a Type Boolean. The one that was left in seem to be the real OutBandwidth looking at the Comment, and has Type F32. My guess is that the deleted entry should not have been deleted, but that the key of this entry is wrong, and that the correct way to fix this is to change the key into whatever it was intended to be. - Aleric On 2010-12-14 12:39:34, Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/18/ > ----------------------------------------------------------- > > (Updated 2010-12-14 12:39:34) > > > Review request for Viewer. > > > Summary > ------- > > I wrote two programs that use settings.xml to produce this massive table: > http://wiki.secondlife.com/wiki/Debug_Settings > > While doing this I found 4 places with duplicate entries and 1 entry that is > repeated 4 times. There is also a pair of unnecessary tags. > > Having these cleaned out would make running my program, and thus updating the > wiki table, easier. > > I've erased all but the last entry for these redundant debug settings. > > > This addresses bug vwr-24100. > http://jira.secondlife.com/browse/vwr-24100 > > > Diffs > ----- > > indra/newview/app_settings/settings.xml 46a990f8296f > > Diff: http://codereview.secondlife.com/r/18/diff > > > Testing > ------- > > > Thanks, > > Jonathan > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
