> On Dec. 16, 2010, 8:04 a.m., Aleric Inglewood wrote: > > indra/newview/app_settings/settings.xml, line 1165 > > <http://codereview.secondlife.com/r/18/diff/1/?file=60#file60line1165> > > > > Considering the setting name (CacheLocationTopFolder), isn't the > > deleted Comment string better than the one you left in? Thus, Controls the > > top folder location of the the local disk cache, rather than Controls the > > location of the local disk cache. Diff is ok with me, I just wondered if > > you saw that it wasn't an exact duplicate.
I adjusted the file per your observation. Apparently this setting was cloned from the one above it (CacheLocation) twice and the comment only updated in one of the copies. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/18/#review32 ----------------------------------------------------------- On Dec. 23, 2010, 12:12 p.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/18/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2010, 12:12 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > I wrote two programs that use settings.xml to produce this massive table: > http://wiki.secondlife.com/wiki/Debug_Settings > > While doing this I found 4 places with duplicate entries and 1 entry that is > repeated 4 times. There is also a pair of unnecessary tags. > > Having these cleaned out would make running my program, and thus updating the > wiki table, easier. > > I've erased all but the last entry for these redundant debug settings. > > > This addresses bug vwr-24100. > http://jira.secondlife.com/browse/vwr-24100 > > > Diffs > ----- > > indra/newview/app_settings/settings.xml 46a990f8296f > > Diff: http://codereview.secondlife.com/r/18/diff > > > Testing > ------- > > > Thanks, > > Jonathan > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
