-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 28/08/16 21:42, Steffan Karger wrote:
> Previously, we would use the compiler's default C version, which
> defaults to gnu89 for GCC < 5, gnu11 for GCC > 5, and c11 for
> clang, but might even differ per distro.
>
> One of the reasons to accept the gnu89 default of GCC < 4.9, was
> that MSVC didn't support c99. But in MSVC 2015, MS finanally fixed
> that.
>
> Having to support c89 in the codebase occasionally forces us to
> write less readable code, for example by forcing all declaration to
> be at the starting of a block (which includes 'for loop initial
> declarations').
>
> Let's be clear about what standard we obey, and stop punishing
> ourselves with c89/gnu89. Let's switch the master branch to c99.
>
> Signed-off-by: Steffan Karger <stef...@karger.me> --- configure.ac
> | 1 + 1 file changed, 1 insertion(+)
>
> diff --git a/configure.ac b/configure.ac index 9189c94..16cab19
> 100644 --- a/configure.ac +++ b/configure.ac @@ -1125,6 +1125,7 @@
> if test "${enable_pkcs11}" = "yes"; then ) fi
>
> +CFLAGS="${CFLAGS} -std=c99" if test "${enable_pedantic}" = "yes";
> then enable_strict="yes" CFLAGS="${CFLAGS} -pedantic"
>
I so much wants to give this an ACK. But this breaks CentOS 5 builds
very badly. The glibc-headers isn't prepared for C99 on that distro.
I took the latest git master where I could do a successful build.
Then I applied just this patch, and here is the explosion:
<http://paste.fedoraproject.org/417049/14725031/>
To move towards C99, we need to add some tricks which makes this not
requiring users to overwrite C99 with C89. That should happen
automatically.
Some CentOS 5.11 details:
glibc-2.5-123.el5_11.3
glibc-headers-2.5-123.el5_11.3
gcc-4.1.2-55.el5
openssl-0.9.8e-40.el5_11
lzo-2.02-2.el5.1
- --
kind regards,
David Sommerseth
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
iQIcBAEBAgAGBQJXxJ8AAAoJEIbPlEyWcf3y9/AP/2ArG2hclq5B48K7/c5pddg5
TC9QY2fgI/NoUGTTzOz7K3Pmzqo98pRAJPlItHZuQGnMsI4mUUoGz5AJxY31faSk
GqrXsJw87IMiPT1ZVSiUeNOLgA7drUHjQo9fe4uzZKfY+pIQcP09cOjWyyjPdiWm
1I4AqSuqawrva7cPVdIMQ/mxQA6SPFqCOF4y9wL2u6he1G7w9D3loomq5SP4zTQ9
wkarGmJ5x7bzLH/5C5Wl/s0yD0lWKG0FSaAelPw5+h4qxIXSMKhVNhapohJ7zUfX
YW+yVH5+pROAvGg/VgGdvdthPPqlodJSi4hIgkgRqtBnyhp+zzGjbvmCE2aL0DtN
XXx2FZppAbZzUgdvfCBjjElmtz0y4v2cewgTO/5f9Aumj/JDSpwbOgrCfSiwrqvh
OWsDPhnliYWacELUvEmK3M/tQHAfIVP307fy8ZgUtkwh/H4hLI+m7AaTOyzo7a73
PmcjtBVe1VLKBq1PDM9IORO7dAz7ApecuLoTe3BrhXF+lDe4DLaUxQhWHocl+Gwr
YhFPny4PyV7kAUNrsReZHxYC04cHvKxG4lh5LJg+jqXnF5obuRM6jBjPKdyo4HW5
qwyD6osMV9DK9BByQY8ClypufBa0ABVJYKUDtUgVl/Rl05mhsLJLlFi2AP4FQMcr
+5rF+M2E5JyR7mysH6cA
=VCb4
-----END PGP SIGNATURE-----
------------------------------------------------------------------------------
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
