On 13/12/16 21:10, Steffan Karger wrote: > Hi, > > On 13-12-16 20:54, Selva Nair wrote: >> >> On Tue, Dec 13, 2016 at 1:55 PM, Steffan Karger <stef...@karger.me >> <mailto:stef...@karger.me>> wrote: >> >> > >> > On 09/12/16 22:27, Steffan Karger wrote: >> > > >> > > Sounds like we have a final config on the CodeStyle page now. >> Are we >> > > ready to run it on all code now, and publish a reformat branch? >> > > >> > >> > Agreed. I can do this later this night. >> > >> > Wait a minute we may need cmt_cpp_to_c=true -- I saw some C++ comments >> > (added by uncrustify) in header files against #endif etc.. >> >> Indeed, tested and added to the CodeStyle page. Anyone up for creating >> the reformatting branch? >> >> >> I did some test over the weekend. For what its worth just pushed the branch >> to https://github.com/selvanair/openvpn/tree/uncrustify >> >> This uses all options at the CodeStyle page plus >> sp_bool=add > > This makes sense. > >> sp_arith=add > > I think we agreed on IRC to not touch arithmetic spacing, because > clarity really depends on the code.
Ouch ... there were a few places, where this really needed to be cleaned
up, otherwise it was really not good.
>> pos_bool=lead
>
> What does this do exactly? The description "The position of boolean
> operators in wrapped expressions" from --show-config doesn't ring a bell
If it breaks a boolean expression over more lines, the operator comes as
the lead character on the following line
i = TEST1
| TEST2
| TEST3
instead of
i = TEST1 |
TEST2 |
TEST3
--
kind regards,
David Sommerseth
OpenVPN Technologies, Inc
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
