According to the Realtek SDK code, the RTL8214FC, RTL8218B and RTL8218FB
all have the same chip ID 0x6276. Let's add a constant for it, as we're
using it in more than one location.

Signed-off-by: Stijn Tintel <st...@linux-ipv6.be>
---
 .../linux/realtek/files-5.15/drivers/net/phy/rtl83xx-phy.c  | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/target/linux/realtek/files-5.15/drivers/net/phy/rtl83xx-phy.c 
b/target/linux/realtek/files-5.15/drivers/net/phy/rtl83xx-phy.c
index 56e8a7f49d..490020989f 100644
--- a/target/linux/realtek/files-5.15/drivers/net/phy/rtl83xx-phy.c
+++ b/target/linux/realtek/files-5.15/drivers/net/phy/rtl83xx-phy.c
@@ -46,6 +46,8 @@ extern struct mutex smi_lock;
 /* external RTL821X PHY uses register 0x1e to select media page */
 #define RTL821XEXT_MEDIA_PAGE_SELECT   0x1e
 
+#define RTL821X_CHIP_ID                        0x6276
+
 #define RTL821X_MEDIA_PAGE_AUTO                0
 #define RTL821X_MEDIA_PAGE_COPPER      1
 #define RTL821X_MEDIA_PAGE_FIBRE       3
@@ -834,7 +836,7 @@ static int rtl8380_configure_ext_rtl8218b(struct phy_device 
*phydev)
        /* Read internal PHY ID */
        phy_write_paged(phydev, 31, 27, 0x0002);
        val = phy_read_paged(phydev, 31, 28);
-       if (val != 0x6276) {
+       if (val != RTL821X_CHIP_ID) {
                phydev_err(phydev, "Expected external RTL8218B, found PHY-ID 
%x\n", val);
                return -1;
        }
@@ -1331,7 +1333,7 @@ static int rtl8380_configure_rtl8214fc(struct phy_device 
*phydev)
        phy_write_paged(phydev, 0, RTL821XEXT_MEDIA_PAGE_SELECT, 
RTL821X_MEDIA_PAGE_COPPER);
        phy_write_paged(phydev, 0x1f, 0x1b, 0x0002);
        val = phy_read_paged(phydev, 0x1f, 0x1c);
-       if (val != 0x6276) {
+       if (val != RTL821X_CHIP_ID) {
                phydev_err(phydev, "Expected external RTL8214FC, found PHY-ID 
%x\n", val);
                return -1;
        }
-- 
2.43.2


_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to