On Wed, Apr 3, 2024 at 11:13 AM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Wed, Apr 3, 2024 at 9:36 AM Bharath Rupireddy > <bharath.rupireddyforpostg...@gmail.com> wrote: > > > I quickly looked at v8, and have a nit, rest all looks good. > > > > + if (DecodingContextReady(ctx) && found_consistent_snapshot) > > + *found_consistent_snapshot = true; > > > > Can the found_consistent_snapshot be checked first to help avoid the > > function call DecodingContextReady() for pg_replication_slot_advance > > callers? > > > > Okay, changed. Additionally, I have updated the comments and commit > message. I'll push this patch after some more testing. >
Pushed! -- With Regards, Amit Kapila.
