"Robert Haas" <[EMAIL PROTECTED]> writes: > Looking forward to v20.
Here you go! I addressed all the nitpicks and added comments. I also stripped out the sequential i/o posix_fadvises. I'm kind of sad to see them go since it did seem like a nice way to give more info to the OS even if no OSes today make good use of it. But one thing at a time and this is clearly a lot more important. Today we're effectively not using raid arrays properly at all, we're using them like they're single drives. One thing which is bothering me is that the guc assign hook is throwing an error if you set effective_io_concurrency when your system's posix_fadvise is deemed inadequate (either unavailable or from an old version of glibc). I'm starting to think it shouldn't throw an error, just not set the internal variable and possible output a warning. We do have some GUC variables which throw errors if you use them and support isn't compiled in, but I'm not sure it's such a hot idea even for those.
posix-fadvise-v20.patch.gz
Description: Binary data
-- Gregory Stark EnterpriseDB http://www.enterprisedb.com Ask me about EnterpriseDB's RemoteDBA services!
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
