Hi Soren, You are right, I'll change first commit so that DSPr2 support is enabled by default and people can disable it at configure time if they want to run pixman on hardware without DSPr2 extensions. I'll do this similarly as -msse2 flag is enabled for SSE optimizations and send first patch again.
Thanks, Nemanja Lukic -----Original Message----- From: Søren Sandmann [mailto:sandm...@cs.au.dk] Sent: Thursday, February 16, 2012 3:06 AM To: Lukic, Nemanja Cc: pixman@lists.freedesktop.org Subject: Re: [Pixman] [PATCH] MIPS: DSPr2: Basic infrastructure for MIPS architecture "Lukic, Nemanja" <nlu...@mips.com> writes: > Run-time detection of the DSP extensions is left as it was in the > original patch. Yes, there is no easy way to run-time distinguish if > CPU supports DSPr1 or DSPr2. In case of "ddsp" string in the cpuinfo, > we don't want to return TRUE. TRUE should be returned only if there is > just "dsp" string found. As mentioned, if DSPr1 and DSPr2 can't be distinguished at runtime, then I don't think it makes sense to do runtime detection at all. I didn't read all of the assembly since I'm not very familiar with MIPS assembly, but the parts I did read looked good to me, so if you send another version of the first patch addressing the -mdspr2 and runtime detection issues, I'll push both patches. Thanks, Søren _______________________________________________ Pixman mailing list Pixman@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pixman
