On Sunday, November 28, 2010, Aaron J. Seigo wrote: > that's very unfortunate, really :(
to fully explain the unfortunateness and why "just set the theme to something else internally" is quite so straightforward, Svg also needs to maintain the ability to set the Theme for the object via Svg::setTheme, while maintaining that "other theme" for caching and coloring when the Svg itself is not themed. denying setTheme calls when it is not themed means requiring setting the imagePath first, which just seems brittle (calls the rely on the order of other calls in non-obvious ways) it would probably also be defensible to say, "if you use setTheme on an Svg that doesn't use a theme Svg file, you're program is buggy. but that, too, seems fragile. separating the caching out of Theme and into a caching object occurred to me, but then it's not just the caching that is needed but also the colors and then we have most of Theme all over again. meh.. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
